Skip to content

Conversation

lizlooney
Copy link
Collaborator

Update mrc_call_python_function mrcOnLoad method to check whether a mechanism component is now a private component.

Removed field mrcComponentNames. It only needs to be a local variable in mrcOnLoad.

Added method Editor.getPrivateComponentsFromMechanism.

Fixes #229

…echanism component is now a private component.

Removed field mrcComponentNames. It only needs to be a local variable in mrcOnLoad.

Added method Editor.getPrivateComponentsFromMechanism.
@lizlooney lizlooney requested a review from alan412 September 19, 2025 05:17
Copy link
Collaborator

@alan412 alan412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. In my original testing, I thought I had found a bug but it turns out I ran into the bug fixed in another PR about the blocks not being reloaded now that they are in different workspaces.

I did request that the warning use internationalization.

Copy link
Collaborator

@alan412 alan412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan412 alan412 merged commit b0a4682 into wpilibsuite:main Sep 21, 2025
1 check passed
@lizlooney lizlooney deleted the pr_issue_229 branch September 22, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When you move a component from public to private, the warning that you get “no longer exists” needs to change

2 participants